Skip to content

[Framework] Read env var SYMFONY_IDE by default for framework.ide #16315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2021
Merged

[Framework] Read env var SYMFONY_IDE by default for framework.ide #16315

merged 1 commit into from
Dec 27, 2021

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Dec 22, 2021

Fix #16232
friendly ping @GromNaN (very useful :))

@94noni 94noni changed the base branch from 6.0 to 6.1 December 22, 2021 15:49
@GromNaN
Copy link
Member

GromNaN commented Dec 22, 2021

Thank you @94noni. Could you update the default value also.

@94noni
Copy link
Contributor Author

94noni commented Dec 22, 2021

@GromNaN please see bb2b5fb if it is what you meant, thanks

@javiereguiluz javiereguiluz added this to the 6.1 milestone Dec 27, 2021
@javiereguiluz
Copy link
Member

Thanks Antoine.

@javiereguiluz javiereguiluz merged commit 5c05f26 into symfony:6.1 Dec 27, 2021
@javiereguiluz
Copy link
Member

Please note that while merging this, I removed the entire config example that used an env var, because the good thing of this feature is that you only need to configure the SYMFONY_IDE env var and do nothing else.

@94noni 94noni deleted the patch-11 branch December 27, 2021 15:52
@javiereguiluz javiereguiluz mentioned this pull request Dec 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@94noni @GromNaN @javiereguiluz @carsonbot